chore: Remove lazy loading for hook registration#22443
Draft
timfish wants to merge 9 commits into
Draft
Conversation
Contributor
size-limit report 📦
|
timfish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the hooks
register.tsto remove all the lazy loading.This involves:
@sentry/server-utilstoexternalso thatregister.tscan always resolve the hook because it's running innode_modules- Also remove passingtracingHooksPathfrom previous workaroundhook-sync.mjsexactly as it would a CJS package, so Next'shandleExternalsESM guard never gets a chance to inspect and throw on it@sentry/nodesize limit by ~80kb. The obfuscation stopped this being bundled and reported in the total size beforeThe remaining failures are down to:
meriyahexport map Nitro/Rollup issue nodejs/orchestrion-js#100--require#22513